Support import gzip json file #547
Conversation
…d in the source code
…'if-not-exists' in 'ongr:es:index:create' command
…sts' in create index command.
…'if-not-exists' in 'ongr:es:index:create' command
…sts' in create index command.
… of testcases to avoid impacting on each other.
|
First of all rebase all merge type commits. Let's try to keep a nice git history. |
|
You forgot to add close comment for the specific issue. |
| @@ -38,7 +38,13 @@ protected function configure() | |||
| InputOption::VALUE_NONE, | |||
| 'If the time suffix is used, its nice to create an alias to the configured index name.' | |||
| ) | |||
| ->addOption('no-mapping', null, InputOption::VALUE_NONE, 'Do not include mapping'); | |||
| ->addOption('no-mapping', 'nm', InputOption::VALUE_NONE, 'Do not include mapping') | |||
There was a problem hiding this comment.
Options shortcut should have not more than one letter. In this particular case let's leave this option without shortcut.
There was a problem hiding this comment.
Oh, sorry for the comment, this commit is not related to this PR. Isn't it. There is something messed up with your git history...
|
Sorry @saimaz , I will check again coveralls and add 'close issue'. |
|
Please do a rebase. Now it's somehow combined with other PR's. |
|
Got it, @saimaz |
|
I will check again all, and inform to you on finish. Thanks. |
|
No idea what you are doing here, but here's the instruction https://akrabat.com/the-beginners-guide-to-rebasing-your-pr/ |
|
Yup, I did it. I included 2 implementations of the issue #423 & #382 to this PR (I will close the other PR related to #423 later).
In the test class, the orders of test cases will impact on each other. Data was born in previous test cases could affect on later test cases. |
|
Please open a new well-formed PR with appropriate changes. |
|
Yup, I will do it. Thanks @saimaz . |
Please review my implementation of supporting gzip file.