Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z Sorting #13

Closed
TheConBot opened this issue Feb 24, 2024 · 8 comments
Closed

Z Sorting #13

TheConBot opened this issue Feb 24, 2024 · 8 comments
Labels
confirmed Issue has been reproduced enhancement New feature or request fix planned A fix is planned but no ETA yet

Comments

@TheConBot
Copy link

Hello! I just discovered this addon the other day and I think its a huge help for reading game text. One thing I would like to suggest is if its possible to introduce some sort of Z Sorting setting, if that is even possible with the UI framework being used, to have this addon render over all other game UI and other loaded addons.

It specifically has an interesting interaction with the HXUI addon, where the sprite and text are rendered over the HXUI text but not the sprites. It would be great if there was either a "force to front" toggle or being able to set a sort priority. Pictures below to illustrate what I mean. Thanks for considering and developing this addon!

image
image

@onimitch
Copy link
Owner

onimitch commented Feb 26, 2024

To help explains what's going on here, theres a few different ways stuff is being displayed.

Most of the text in HXUI is being displayed using Ashita fonts library.
Balloon uses a similar method to the Ashita fonts but using a custom library called gdifonts made by Thorny.

The rest of HXUI is rendered using IMGUI, which is a UI framework that Ashita v4 offers.

If HXUI is loaded before Balloon, Balloon's elements should usually cover what's been rendered using Ashita fonts. However, IMGUI will always render after everything else, which means out of the box we have no way to force Balloon to sit on top of IMGUI.

One idea I have which I'll try when I get some time, would be to offer an option to render Balloon in IMGUI. Which would mean we could force it to the front. It might not be as performant but maybe it'd be good enough as an optional toggle for those that need it.

I'll update here once I've had a chance to look into it.

@onimitch onimitch added enhancement New feature or request confirmed Issue has been reproduced labels Feb 26, 2024
@TheConBot
Copy link
Author

TheConBot commented Feb 27, 2024 via email

@onimitch
Copy link
Owner

@TheConBot RE the battle suggestion, I've added a new ticket for that: #14

As for the z-ordering issue:

スクリーンショット 2024-02-28 15 15 39

I need to do some testing with it, but hopefully I can post a new release for it in the next few days.

@onimitch onimitch added the fix planned A fix is planned but no ETA yet label Feb 28, 2024
@TheConBot
Copy link
Author

TheConBot commented Feb 28, 2024 via email

@onimitch
Copy link
Owner

@TheConBot thanks!

@onimitch
Copy link
Owner

Just FYI there was an exception occuring from my last changes relating to the battle checking. It seemed to only occur during cutscenes. If you've got my changes from earlier, i've pushed a fix now to main.

@TheConBot
Copy link
Author

TheConBot commented Feb 29, 2024 via email

@onimitch
Copy link
Owner

onimitch commented Mar 8, 2024

Fixed in 4.2.0

@onimitch onimitch closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue has been reproduced enhancement New feature or request fix planned A fix is planned but no ETA yet
Projects
None yet
Development

No branches or pull requests

2 participants