Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how does 0 value_id work? #279

Open
hydrargyrum opened this issue Mar 25, 2024 · 1 comment
Open

how does 0 value_id work? #279

hydrargyrum opened this issue Mar 25, 2024 · 1 comment

Comments

@hydrargyrum
Copy link

The file_tag table contains value_id INTEGER NOT NULL column and FOREIGN KEY (value_id) REFERENCES value(id) constraint so it seems a file-tag link MUST have a value. But after using tmsu to create file-tag links without a value, I have:

sqlite> select count(*) from file_tag where value_id = 0;
4
sqlite> select count(*) from value where id = 0;
0

So how can file_tag.value_id reference a non-existing value.id, what sorcery is this?

@0ion9
Copy link

0ion9 commented Mar 26, 2024

As far as I can see, this is the answer:

Assuming the library is compiled with foreign key constraints enabled, it must still be enabled by the application at runtime, using the PRAGMA foreign_keys command. For example:

sqlite> PRAGMA foreign_keys = ON;

Foreign key constraints are disabled by default (for backwards compatibility), so must be enabled separately for each database connection.

My grepping suggests that TMSU never enables the above pragma. I'm not sure what it is worth that entering PRAGMA foreign_keys; to query the value returns 0 on a freshly initialized TMSU db, but I guess it counts as some evidence that it is not enabled by default on the database; I'm unsure whether 'enabled by default on the database' is a sensible possibility or not (maybe it's strictly the application runtime has to choose every time)

Now, it is the case that turning this pragma ON in sqlite3 has no immediate effects. I'm not interested in testing further, but given the description of how foreign key constraints work, you may find that turning the pragma ON and then making some modification to the file_tag table triggers an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants