Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Provide an option to configure the command palette appearance #714

Closed
badosu opened this issue Sep 18, 2017 · 5 comments
Closed

Provide an option to configure the command palette appearance #714

badosu opened this issue Sep 18, 2017 · 5 comments

Comments

@badosu
Copy link
Collaborator

badosu commented Sep 18, 2017

This is how it's displayed on a high DPI high, font size screen:

screenshot from 2017-09-18 17-32-07

@jordwalke
Copy link

Maybe we could start also by making its hue match the OneDark color theme (right now the command pallet has a warm hue and the OneDark base color is cooler (more blue)).

@bryphe
Copy link
Member

bryphe commented Sep 25, 2017

Thanks for logging the issue @badosu ! This is very ugly. I believe it is the same issue in #713 (using pixels for font sizing), and would have a similiar fix.

The hue / colors are a good point too - I experimented a bit with using colors based on the current background / foreground colors of the vim colorscheme.

@bryphe
Copy link
Member

bryphe commented Oct 4, 2017

This should be addressed with PR #749. I couldn't repo the High-DPI issue though unfortunately, but I believe it's due to a mismatch with font-size pixel vs point. The change uses em sizing for Oni's UI, so that it is a derivative of the font size specified in the settings. There were lots of places in CSS we used pixels, which would be problematic.. Feel free to reopen if you're still seeing this.

@bryphe bryphe closed this as completed Oct 4, 2017
@badosu
Copy link
Collaborator Author

badosu commented Oct 4, 2017

I wil create an oni-git package to try and reproduce from master branch.

@badosu
Copy link
Collaborator Author

badosu commented Oct 10, 2017

👍 Works great, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants