Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Fix #714 - Menu styles + font sizing issues #749

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Oct 3, 2017

Address a couple of issues with the menu:

  • Use the foregroundColor and backgroundColor from the current color theme, and no hardcoded colors.
  • Use em instead of px for font-sizes here, since px doesn't work correctly for HDPI displays. We should use pt as the font sizes.

Remaining issues:

  • Update default font size to pt on Linux/Mac

@bryphe
Copy link
Member Author

bryphe commented Oct 3, 2017

Fixes #714

@bryphe
Copy link
Member Author

bryphe commented Oct 3, 2017

New look against the default onedark colorscheme:
image

And in solarized8_light:
image

Not perfect, but it is better than before, and an incremental step. Once there is more thorough sync'ing of the colorschemes, we'll be able to do a bit better with the highlight colors.

@bryphe bryphe changed the title Fix #741 - Menu styles + font sizing issues Fix #714 - Menu styles + font sizing issues Oct 3, 2017
@bryphe
Copy link
Member Author

bryphe commented Oct 3, 2017

(Moving remaining fix - updating default font sizes - to a separate fix to improve font rendering).

@bryphe bryphe merged commit 402012b into master Oct 3, 2017
@bryphe bryphe deleted the bryphe/714.1/command-palette-colors branch October 3, 2017 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant