[WIP] Solarized theme

[akinsho]

@bryphe hopefully matches what you had in mind, the theme is called solarized8 being a fork which I stuck to so it's clear where it came from

[bryphe]

Awesome, thanks for putting this together, @Akin909 ! I know @hoschi will appreciate it 😉

When I set my ui.colorscheme to it, I see this:

I think it is picking up the light version instead of the dark version.

For Solarized, I believe it would make sense to have two themes:

• Solarized Dark and Solarized Light.

We could reference both versions in the package.json, like:

"contributes": {
    "themes": [
{ "name": "solarized8_light", "path": "colors/solarized8_light.json"}
{ "name": "solarized8_dark", "path": "colors/solarized8_dark.json"}
]
}

Sorry for the formatting, hopefully that helps give an idea.

[hoschi]

@Akin909 AWESOME 💯
I still sit on b64f415 from 7 weeks ago and I think after this one I can upgrade again and get working syntax highlighting \o/

[hoschi]

@bryphe your screenshot hasn't syntax highlighted I realize after my last comment. Does it work with the new theme?

[akinsho]

Ah completely forgot that background defaults to light in vim unless background=dark, i'll have another look at these, and split them out

[bryphe]

Awesome, I just tried this out, and it works great for me (using both solarized8_dark and solarized8_light as settings for ui.colorscheme).

Is there anything left here, @Akin909 ? Or is it ready to bring in?

[bryphe]

@hoschi - I don't think I had the experimental.editor.textMateHighlighting.enabled flag set to true in that screenshot. It looks like there is syntax highlighting when I have that set:

[bryphe]

This looks like it's all set - thanks @Akin909 for integrating this! I'll bring this in now. We're starting to have a nice portfolio of first-class themes supported - onedark, solarized light/dark, nord. Very cool.