This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix #1178 - Incorrect client capabilities #1185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Oni isn't able to take advantage of the code completion functionality w/
go-langserver
.Defect: We're not sending a properly formed client capabilities request - this causes problems for the language server when deserializing.
Fix: Update our client capabilities to adhere to the spec and more accurately represent the supported set of features Oni can leverage.