This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Feature/toggle sidebar #1424
Closed
Feature/toggle sidebar #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So is there a way to bind a toggle command for the sidebar in |
|
There unfortunately isn't a good way right now - but you can set |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst I absolutely love the sidebar I couldn't bear having it open all the time so this PR aims to add toggleability its very simply implemented toggling a boolean in redux and adding an Oni command, wasn't sure if you had a plan for this as part of a larger split handling bit of functionality but I implemented this locally, if it's not quite not what you intended no worries 👍 , as I know there #1363 etc and #1412 and you'd discussed different means of handling splits