Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Add Hybrid and Gruvbox themes #2088

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

parkerault
Copy link
Contributor

This PR depends on #2083

Add a port of the Hybrid theme: https://github.com/w0ng/vim-hybrid

Screenshots:

image

image

...and also Gruvbox: https://github.com/morhetz/gruvbox

Screenshots:

image

image

@parkerault parkerault changed the base branch from master to bryphe/theming/specify-background-theme April 13, 2018 05:40
@parkerault
Copy link
Contributor Author

@bryphe I set the base branch to your WIP for baseVimBackground so they can get released together. Let me know if you would rather set it up some other way.

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #2088 into bryphe/theming/specify-background-theme will increase coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@                             Coverage Diff                             @@
##           bryphe/theming/specify-background-theme    #2088      +/-   ##
===========================================================================
+ Coverage                                    36.79%   36.81%   +0.02%     
===========================================================================
  Files                                          288      288              
  Lines                                        11424    11417       -7     
  Branches                                      1540     1537       -3     
===========================================================================
  Hits                                          4203     4203              
+ Misses                                        6984     6977       -7     
  Partials                                       237      237
Impacted Files Coverage Δ
...rowser/src/Services/WindowManager/WindowManager.ts 66.35% <100%> (ø) ⬆️
...rowser/src/Services/Explorer/ExplorerFileSystem.ts 76.92% <85.71%> (ø) ⬆️
browser/src/Services/Themes/ThemeManager.ts 60.52% <0%> (ø) ⬆️
browser/src/Editor/NeovimEditor/NeovimEditor.tsx 9.4% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9388783...0b9e229. Read the comment docs.

@bryphe
Copy link
Member

bryphe commented Apr 14, 2018

@parkerault - these look great! Nice work 👍 I'm going to have to take the Hybrid theme for a test drive..

@bryphe I set the base branch to your WIP for baseVimBackground so they can get released together. Let me know if you would rather set it up some other way.

Perfect, that makes sense! I'm just wrapping it up now. I added a CiTest to validate that background gets set appropriately - think it's almost good to go.

@parkerault
Copy link
Contributor Author

@bryphe check out gruvbox; you might not like the colors, but the language support is excellent. I am considering using it as a template for all other themes.

@bryphe
Copy link
Member

bryphe commented Apr 15, 2018

Cool, the syntax highlighting does look much more useful with gruvbox 👍 Showcases the textmate highlighting in a better way.

I brought in #2083 , so you can change the base back to master - and I'll bring this in. Looking forward to trying these out!

@parkerault parkerault changed the base branch from bryphe/theming/specify-background-theme to master April 15, 2018 17:26
@parkerault
Copy link
Contributor Author

@bryphe GTG

@bryphe
Copy link
Member

bryphe commented Apr 15, 2018

Sweet! Thanks a lot for working on these, @parkerault 👍 Bringing them in now!

@bryphe bryphe merged commit c23e28e into onivim:master Apr 15, 2018
@CrossR CrossR mentioned this pull request Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants