Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Pass event names to all Event constructors #2355

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GeorgeTG
Copy link
Contributor

Pass names to all event constructors, first step to fix #2323
Also properly dispose some Event Handlers in tests.

@akinsho
Copy link
Member

akinsho commented Jun 29, 2018

@bryphe when you get a chance would be great to get your input on this issue as it affects quite a bit how events are used in oni as well as oni-types

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #2355 into master will increase coverage by 0.01%.
The diff coverage is 34.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2355      +/-   ##
==========================================
+ Coverage   37.59%   37.61%   +0.01%     
==========================================
  Files         299      299              
  Lines       12464    12464              
  Branches     1643     1643              
==========================================
+ Hits         4686     4688       +2     
+ Misses       7529     7527       -2     
  Partials      249      249
Impacted Files Coverage Δ
...Services/Learning/Tutorial/TutorialBufferLayer.tsx 27.97% <ø> (ø) ⬆️
browser/src/neovim/NeovimWindowManager.ts 10.61% <0%> (ø) ⬆️
browser/src/neovim/NeovimAutoCommands.ts 5.71% <0%> (ø) ⬆️
browser/src/Services/Colors.ts 15% <0%> (ø) ⬆️
browser/src/Services/Notifications/Notification.ts 8.33% <0%> (ø) ⬆️
browser/src/Services/Learning/LearningPane.tsx 28.07% <0%> (ø) ⬆️
browser/src/Services/QuickOpen/FinderProcess.ts 40% <0%> (ø) ⬆️
browser/src/Services/Sneak/Sneak.tsx 14.63% <0%> (ø) ⬆️
browser/src/UI/components/VimNavigator.tsx 15.55% <0%> (ø) ⬆️
browser/src/neovim/NeovimInstance.ts 5.57% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a818e...873b792. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple instances of Event class for the same event cause events being missed
2 participants