Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Feature/Fix incorrect window positions passed to buffer layers #2605

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Oct 3, 2018

This PR adds a call to the remeasure function to derive the window top and bottom lines as previously this was obtained from the various events and the buffer update function was passing incorrect

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #2605 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2605      +/-   ##
=========================================
+ Coverage   45.28%   45.3%   +0.01%     
=========================================
  Files         361     361              
  Lines       14575   14571       -4     
  Branches     1912    1912              
=========================================
  Hits         6601    6601              
+ Misses       7750    7746       -4     
  Partials      224     224
Impacted Files Coverage Δ
browser/src/neovim/NeovimWindowManager.ts 11.21% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a2c93...bd9800e. Read the comment docs.

@@ -167,31 +172,33 @@ export class NeovimWindowManager extends Utility.Disposable {
currentWinId: number,
context: EventContext,
): Promise<NeovimActiveWindowState> {
// We query the top and bottom line positions again despite these being on the context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting - nice catch! 👍

@akinsho akinsho merged commit d354c2c into onivim:master Oct 4, 2018
@akinsho akinsho deleted the feature/fix-incorrect-window-positions-passed-to-layer-context branch October 4, 2018 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants