Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Reduce duplication in .less files #286

Merged
merged 2 commits into from
Mar 10, 2017
Merged

Reduce duplication in .less files #286

merged 2 commits into from
Mar 10, 2017

Conversation

keforbes
Copy link
Collaborator

@keforbes keforbes commented Mar 9, 2017

I noticed there were hardcoded colors in some .less files that were already defined in common.less so this is just some cleanup to use the variable from common.less instead. The only visual change I made was to the detail color in the menu and autocompletion. I think the detail text was too dim so I got rid of the alpha value but kept the color the same.

@keforbes
Copy link
Collaborator Author

keforbes commented Mar 9, 2017

Ok, one more visual change. In the menu, make the mouse hover color slightly dimmer than the selected item color so you can tell the difference.

@bryphe bryphe merged commit 4a52a21 into onivim:master Mar 10, 2017
@bryphe
Copy link
Member

bryphe commented Mar 10, 2017

Thank you for cleaning this up! The changes you made to the detail text and hover color look great - it's a subtle but significant improvement in the completion / popup menu.

@keforbes keforbes deleted the cleanup-less branch March 14, 2017 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants