This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix #822: Improved OSX defaults for QuickOpen and Command Palette #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Most editors on OS X (like VSCode, Sublime, Atom), use
<Command+P>for file finder and<Command+Shift+P>for the command palette. Oni uses the same defaults as Windows,<Control+P>and<Control+Shift+P>, which is not very intuitive, and has the other downside that<Control+P>is double-booked as both previous entry and opening the menu.Fix: Change the defaults on OS X to use
<Command+P>and<Command+Shift+P>. In addition, there was a bug where keys weren't resolved properly ifCommandandShiftwere both pressed, so that was fixed to unblock the scenario.