Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop v0.48.0 #22

Merged
merged 12 commits into from
Mar 29, 2017
Merged

Update rubocop v0.48.0 #22

merged 12 commits into from
Mar 29, 2017

Conversation

onk
Copy link
Owner

@onk onk commented Mar 27, 2017

  • Update rubocop v0.48.0.
  • Disable new Lint/AmbiguousBlockAssociation cop.
  • Disable new Rails/Blank cop.
  • Disable Style/SymbolArray, StyleWordArray cop.
  • Change Style/MultilineMethodCallIndentation to indented_relative_to_receiver style.
  • Exclude RSpec directory from new Style/MixinGrouping cop.
  • Ignore node_modules dir.
  • Add TargetRailsVersion to README and template

onk added 12 commits March 29, 2017 12:12
see: rubocop e6300605cd
The problem of currency exchange does not occur in Japan.
I'm afraid to mistake the digits of the numbers. Foolproof is more important.

rubocop 7796c09a02
If set `Strict` parameter, warning occurs.
Remove it until rubocop: pull/4180 is merged.
Change to `indented_relative_to_receiver` style.
It became very smart.

see: rubocop 586944de63
v0.48.0 has bug that an error occurs if there are `or`.

see rubocop pull/4175
Maybe this cop has many things that looks like false positives.
This cop has false positive for `include` matcher.

```ruby
expect(array).to include("a", "b")
```
This is a legacy when configuration was published in gist.
See onkcop's version.
@onk onk force-pushed the feature/bump_rubocop_v0_48_0 branch from a2caf36 to 347b1f0 Compare March 29, 2017 03:12
@onk onk changed the title [WIP] Update rubocop v0.48.0 Update rubocop v0.48.0 Mar 29, 2017
@onk onk merged commit 7abce39 into master Mar 29, 2017
@onk onk deleted the feature/bump_rubocop_v0_48_0 branch March 30, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant