Update rubocop dependency version to 0.50.0 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new configuration option since v0.50.0 is reasonable. rubocop pull/4514
rubocop pull/4559
It is common sense that just `rescue` means `rescue StandardError`. rubocop issues/2943, pull/4564
rubocop pull/4575
Sometimes conditional expressions may be more important. The same reason as Style/IfUnlessModifier. rubocop pull/4648
```ruby
require "benchmark/ips"
Benchmark.ips do |x|
hash = [*"a".."z"].zip([*1..26]).to_h
x.report("each_key") { hash.each_key { |k| k.upcase } }
x.report("keys.each") { hash.keys.each { |k| k.upcase } }
x.report("each") { hash.each { |k, _| k.upcase } }
end
```
```
Warming up --------------------------------------
each_key 22.511k i/100ms
keys.each 21.115k i/100ms
each 20.680k i/100ms
Calculating -------------------------------------
each_key 244.031k (± 9.5%) i/s - 1.216M in 5.031621s
keys.each 236.148k (±10.5%) i/s - 1.182M in 5.069345s
each 242.460k (± 8.9%) i/s - 1.220M in 5.077224s
```
`keys.each` is a bit slow but `each` and `each_key` are same-ish.
rubocop 2a2b03f806
(Prior to this commit, this cop only checked the variable named `hash`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocopv0.50.0 andrubocop-rspecv1.18.0Performance/HashEachMethodscopStyle/OrAssignmentcopStyletoNamingLint/RescueWithoutErrorClasscopnode_modulesdirectory is now excluded by rubocop as defaultStyle/YodaConditioncop withequality_operators_onlystyle