Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Style/EmptyLineAfterGuardClause cop to Layout department #57

Closed
wants to merge 1 commit into from

Conversation

mkmn
Copy link

@mkmn mkmn commented Aug 29, 2018

see: rubocop/rubocop#5886

Style/EmptyLineAfterGuardClause has the wrong namespace - should be Layout

@onk
Copy link
Owner

onk commented Aug 29, 2018

FYI: #56

I have not seen the changes of v0.53...v0.56.
How is your impression of using it in your project?

@koic
Copy link

koic commented Aug 31, 2018

Layout/EmptyLineAfterGuardClause cop will be enabled by default at the next release of RuboCop (maybe 0.59.0) .
rubocop/rubocop#6235

@libra189
Copy link

libra189 commented Oct 3, 2018

Hello
A new version of RuboCop has been released at 0.59.2.
rubocop-hq/rubocop#6235 has been merged in this version.
Do you plan to make changes in this project?

I'm sorry for my bad English
Have a good day.

@SpringMT
Copy link

How about this PR?

@onk
Copy link
Owner

onk commented Oct 11, 2018

In rubocop v0.59.0, Layout/EmptyLineAfterGuardClause is enabled by default.
So remove the configuration. #58

@onk
Copy link
Owner

onk commented Oct 11, 2018

Released no warning version as v0.53.0.2.
Have you solved the problem with this?

@libra189
Copy link

In rubocop v0.59.0, Layout/EmptyLineAfterGuardClause is enabled by default.
So remove the configuration. #58

Thanks.
I was solve the trouble.
Please close this PR at #57.

@mkmn mkmn closed this Oct 23, 2018
@mkmn mkmn deleted the style_empty_line_after_guard_clause branch October 23, 2018 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants