Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# of viewers on the popup button not always accurate #62

Closed
roy7 opened this issue Mar 2, 2017 · 6 comments
Closed

# of viewers on the popup button not always accurate #62

roy7 opened this issue Mar 2, 2017 · 6 comments
Labels

Comments

@roy7
Copy link
Contributor

roy7 commented Mar 2, 2017

http://puu.sh/uqh6v/c419da25ff.jpg

Consider that screen shot, there's 2 in the lobby but the icon shows 1.

@anoek
Copy link
Member

anoek commented Mar 7, 2017

I've seen this happen though I'm unsure how to reproduce it, any assistance in figuring that out would be appreciated.

@BarneyStratford
Copy link
Contributor

BarneyStratford commented Mar 7, 2017 via email

@anoek
Copy link
Member

anoek commented Mar 7, 2017

Go for it :)

BarneyStratford added a commit to BarneyStratford/online-go.com that referenced this issue Mar 11, 2017
…s the number of spectators in a match works correctly but is not being called when the number of spectators changes. I have a hunch that a setTimeout is throwing an exception that is silently dropped. Add code to log any exceptions thrown, and continue to watch for further occurrences of the bug.
anoek added a commit that referenced this issue Mar 11, 2017
@roy7
Copy link
Contributor Author

roy7 commented Mar 15, 2017

Made a fork game, went into it. someone joined me to test something. Shows it as 1 person there.

http://puu.sh/uJntR/92a87ef357.jpg

He leaves and rejoins, number says 1 the whole time. I press F5, and then it says 2.

@BarneyStratford
Copy link
Contributor

BarneyStratford commented Mar 15, 2017 via email

@anoek
Copy link
Member

anoek commented Mar 27, 2017

Should be now fixed with #181 thanks to @BarneyStratford :)

@anoek anoek closed this as completed Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants