-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# of viewers on the popup button not always accurate #62
Labels
Comments
I've seen this happen though I'm unsure how to reproduce it, any assistance in figuring that out would be appreciated. |
That sounds like an interesting bug. I’ll take it if you like.
Barney.
|
Go for it :) |
BarneyStratford
added a commit
to BarneyStratford/online-go.com
that referenced
this issue
Mar 11, 2017
…s the number of spectators in a match works correctly but is not being called when the number of spectators changes. I have a hunch that a setTimeout is throwing an exception that is silently dropped. Add code to log any exceptions thrown, and continue to watch for further occurrences of the bug.
Made a fork game, went into it. someone joined me to test something. Shows it as 1 person there. http://puu.sh/uJntR/92a87ef357.jpg He leaves and rejoins, number says 1 the whole time. I press F5, and then it says 2. |
I’m seeing the bug too, all too frequently, but never on my dev server. I’m still working on it. I’ll post a fix as soon as I have one, but this is proving tricky. It is definitely not an exception from within the asynchronous code, but looks instead like componentDidMount isn’t even being called. As soon as I call it myself everything’s fine.
Barney.
|
Should be now fixed with #181 thanks to @BarneyStratford :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
http://puu.sh/uqh6v/c419da25ff.jpg
Consider that screen shot, there's 2 in the lobby but the icon shows 1.
The text was updated successfully, but these errors were encountered: