Fix: インクルードガードの前の空行やコメント行を許容するようにしました #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
本件とは少し話が逸れますが、CIが Python の Setup で落ちているので、それを先に修正する必要がありそうです。 |
This was referenced Dec 10, 2022
Closed
kzrnm
reviewed
Dec 10, 2022
There was a problem hiding this comment.
こちらのリポジトリは事実上メンテナンスされてないようなので、自作の移植・改良版を作成したのですが、この issue を移植する 作業で気付いたことがあるので一応コメントしておきます。
https://github.com/competitive-verifier/competitive-verifier より
Comment on lines
348
to
+353
| if uncommented_line: | ||
| non_guard_line_found = True | ||
| if not non_guard_line_found and uncommented_line == b"\n": | ||
| # include guard の前がコメントまたは空行の場合は non_guard_line_found を True にしない | ||
| pass | ||
| else: | ||
| non_guard_line_found = True |
There was a problem hiding this comment.
if uncommented_line and not re.match(rb"^\s*$", uncommented_line): とすると
// インデント付コメント
#pragma onceみたいなのも除外できるのでベターなのではないかと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219 に対応しています
include guardの外側にコードが書かれていた場合を参考に変更しましたのでそちらもお時間あればご確認お願いします。