Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to duplicate the original paper's results #9

Closed
ang-bas opened this issue May 15, 2023 · 6 comments
Closed

Unable to duplicate the original paper's results #9

ang-bas opened this issue May 15, 2023 · 6 comments

Comments

@ang-bas
Copy link

ang-bas commented May 15, 2023

Hello.... I am a new graduate student interested in your work. I was trying to duplicate the results you have on your paper. I ran the main.py following your Readme file, but the resulting F1 scores seem very low. I am curious as to how I should set the parameters or arguments to have the same results with yours. Thank you.

Screenshot from 2023-05-15 14-29-57

@onlyzdd
Copy link
Owner

onlyzdd commented May 17, 2023

@ang-bas Your result seems strange. Please check the following things so that I can spot the problem and help you further:

  1. Do yun run the code with the same Python package requirements? If not, try to run code with the same requirements.
  2. Have you made any changes to the source code and dataset? If yes, paste your modification here.
  3. Are you using exact the same command in the README (which produce the result showing in the screenshot)? If not, paste your command here.
  4. Please paste logs for all epochs here.

@ang-bas
Copy link
Author

ang-bas commented May 18, 2023 via email

@onlyzdd
Copy link
Owner

onlyzdd commented May 19, 2023

@ang-bas Have you closely followed the instructions in the README? I just downloaded the code fro github and data from dropbox, ran model training after preprocessing, and got the output:
image
Notice that I only show first 5 epochs here. But around 20-30 epochs, F1 on the evaluation dataset achieves/exceeds the reported result.
However, in your screenshot, there are some problems:

  1. The training loss is not going down, which means the model is not training at all.
  2. The validation loss is bigger than training loss, which seems impossible since number of validation samples is less than training (1:8).
  3. All AUCs during validation are around 0.5, which also indicates the model is not learning.
    BTW, I ran the code with the following package requirements. So I would suggest you to re-download the code and data, run preprocessing, and run training with no changes.
image

@ang-bas
Copy link
Author

ang-bas commented May 24, 2023 via email

@onlyzdd
Copy link
Owner

onlyzdd commented May 24, 2023

Hi @ang-bas, I'm sorry to hear that the code is not working for you and I'm unable to locate the problem according to your description.
To help you, I created a Colab Notebook which works well. I would also suggest you to run the code with the data on another machine to check whether it works or not.

@onlyzdd
Copy link
Owner

onlyzdd commented Jun 6, 2023

@ang-bas I've also ran the code in the environment with the same package versions you are using. The result agrees with it as reported in the paper.
It's been a long time since your last feedback. Have you tried my suggestions?
As I've attached the Colab Notebook before which is working well. And there're some works based on this project, ECG analysis Using Deep Learning, which shows the results are successfully reproduced.
So now I'm closing this issue as I cannot reproduce your problem. But feel free to reopen and comment with your settings and results.

@onlyzdd onlyzdd closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants