Question: What's required to update Smile to include latest iOS 11.1 emoji (vampire, mermaid, etc)?

[kharmabum]

See: https://blog.emojipedia.org/ios-11-1-emoji-changelog/

[kharmabum]

@onmyway133 I went ahead and compiled a list of the new emoji with associated code points and aliases (I did my best to match the conventions already in Smile). https://gist.github.com/kharmabum/0dc6307a0bbccb8a76f93973db00abce

[Francescu]

@kharmabum does my PR #6 fixed the issue?

[kharmabum]

@Francescu I would say it's mostly sufficient. The lack of gendered versions of a few of the emoji is regrettable, but you may have had a compelling reason to leave those out.

[Francescu]

I’m not aware of those. Could you list which variations are not working so I can try to fix?

[kharmabum]

@Francescu check out the gist I posted above.

[Francescu]

@kharmabum just tested some of the emojis in the gist (🧙‍♀️🧙‍♂️🧛‍♀️🧛‍♂️) and they're working fine with Smile. Please not that while some gendered emojis are not present in Emoji.swift they'll work. Feel free to test and do a quick list here of non-working gendered emojis while Smile.

Thanks for your help 😊

[kharmabum]

🙏👍 - JC

…

________________________________ From: Francescu Santoni <notifications@github.com> Sent: Monday, February 26, 2018 10:00:12 AM To: onmyway133/Smile Cc: Juan-Carlos Foust; Mention Subject: Re: [onmyway133/Smile] Question: What's required to update Smile to include latest iOS 11.1 emoji (vampire, mermaid, etc)? (#5) @kharmabum<https://github.com/kharmabum> just tested some of the emojis in the gist (🧙‍♀️🧙‍♂️🧛‍♀️🧛‍♂️) and they're working fine with Smile. Please not that while some gendered emojis are not present in Emoji.swift<https://github.com/onmyway133/Smile/pull/6/files#diff-2c35896e4293616d55c97d6f56515bbaR1449> they'll work. Feel free to test and do a quick list here of non-working gendered emojis while Smile. Thanks for your help 😊 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#5 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAv0xdUVnmpe4qDgD_96AZiOPSTTZ-Mtks5tYvErgaJpZM4QvV-g>.

[onmyway133]

@Francescu @kharmabum Thanks for your contribution ❤️ If you 'd like to be make more changes, I 'd be very happy to add you as contributors to the project