Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ONNX-MLIR to ONNX v1.12.0 release. #1808

Closed
mikeessen opened this issue Oct 25, 2022 · 8 comments
Closed

Upgrade ONNX-MLIR to ONNX v1.12.0 release. #1808

mikeessen opened this issue Oct 25, 2022 · 8 comments

Comments

@mikeessen
Copy link
Collaborator

@AlexandreEichenberger @chentong319 @hamptonm1 @cjvolzka

ONNX release v1.12.0 has been made available earlier this year. Detail for the updates included are described on the ONNX releases web page https://github.com/onnx/onnx/releases.

The ai.onnx opset version increased to 17 with the new operators: SequenceMap, LayerNormalization, DFT, HannWindow, HammingWindow, BlackmanWindow, MelWeightMatrix, and STFT.

The Scan operator was updated to remove an unused type constraint, but the version remains as opset 16.

Also included in the release are shape inference enhancements, bug fixes, infrastructure improvements, documentation updates, and wheel changes.

Let’s use this issue is to discuss moving to ONNX v1.12.0. We plan on working on this without initially providing support for the new operators.

Note that the TreeEnsembleClassifier and TreeEnsembleRegressor operators show up as version 1 in ONNX-MLIR but were updated to version 3 in ONNX v1.11.0.

@mikeessen
Copy link
Collaborator Author

The SupportedONNXOps-cpu.md document at https://github.com/onnx/onnx-mlir/blob/main/docs/SupportedONNXOps-cpu.md states that TreeEnsembleClassifier and TreeEnsembleRegressor are unsupported. Is the document correct? Should these be updated to version 3 in ONNX-MLIR when we move ONNX to v1.12.0?

@AlexandreEichenberger
Copy link
Collaborator

@mikeessen That is correct, we currently don't have code that lower these ops to CPU reference code. We typically mention a version only for the ops we support.
If some of these ops are important to your projects, we encourage folks to contribute their implementations.

@hamptonm1
Copy link
Collaborator

@mikeessen That is correct, we currently don't have code that lower these ops to CPU reference code. We typically mention a version only for the ops we support.
If some of these ops are important to your projects, we encourage folks to contribute their implementations.

This looks good to me @mikeessen! Thanks for putting this together. Also @cjvolzka is it important to support these ops that @mikeessen mentioned or are we fine with what we are inheriting from onn-xmlir ?

@chentong319
Copy link
Collaborator

PR #1835 added the new Ops into onnx-mlir's ONNX dialect definition. Further implementation support is needed

@hamptonm1
Copy link
Collaborator

PR #1835 added the new Ops into onnx-mlir's ONNX dialect definition. Further implementation support is needed

Thanks for the information.... I am assuming @mikeessen will still update the documentation for this?

@mikeessen
Copy link
Collaborator Author

@hamptonm1 @chentong319 Yes, I will update SupportedONNXOps-cpu.md for this.

@hamptonm1
Copy link
Collaborator

@hamptonm1 @chentong319 Yes, I will update SupportedONNXOps-cpu.md for this.

FYI @philass so you do not have to do duplicate work :)

@cjvolzka
Copy link
Collaborator

cjvolzka commented Dec 8, 2022

Closing issue as completed as onnx-mlir has moved to onnx 1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants