Fix wrong opset version in model downloading #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11 (the opset version of the latest stable), but 10
|
The CI errors are not related to this PR |
linkerzhang
approved these changes
Dec 3, 2019
|
onnx/models#141 |
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
…11 (the opset version of the latest stable), but 10 (onnx#2478) Co-authored-by: Ke Zhang <kezhan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As what has been repeatedly pointed in #2049, the opset version in the URLs of models should not be
onnx.des.onnx_opset_version(). After waiting for a fix for a long time, I found it is easy to fix by maintaining a separate opset version.The opset version should have been updated to 11 (the opset version of the latest stable release of ONNX), but URLs like https://s3.amazonaws.com/download.onnx/models/opset_11/vgg19.tar.gz are still invalid :| They seems ignored by ONNX maintainers. In order to keep fresh contributors from feeling confused and frustrated as soon as possible, I set the opset version to 10 for now.