Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a release pipeline for Windows python packages #2632

Merged
merged 6 commits into from
Mar 3, 2020
Merged

Add a release pipeline for Windows python packages #2632

merged 6 commits into from
Mar 3, 2020

Conversation

snnn
Copy link
Contributor

@snnn snnn commented Feb 29, 2020

To replace https://github.com/onnx/wheel-builder

Sample run: https://github.com/snnn/onnx/actions/runs/47068032
You can download the wheels from there and try it.

@snnn snnn requested review from a team as code owners February 29, 2020 01:31
@lgtm-com
Copy link

lgtm-com bot commented Feb 29, 2020

This pull request introduces 1 alert when merging 6b73f09 into e8b33a5 - view on LGTM.com

new alerts:

  • 1 for Unused import

@chinhuang007
Copy link
Contributor

Just installed a wheel (win64 + py38) successfully. I think this should be included in release 1.7.

@chinhuang007 chinhuang007 added this to the 1.7 milestone Mar 2, 2020
@linkerzhang
Copy link
Member

Thank you so much! @snnn

Quick questions: does this mean we'll need wheel-builder for Linux packages and this for windows packages? if yes, shall we put them in one place please?

@snnn
Copy link
Contributor Author

snnn commented Mar 3, 2020

Quick questions: does this mean we'll need wheel-builder for Linux packages and this for windows packages? if yes, shall we put them in one place please?

That will be better. But it will take me a few days more and I think currently the top priority thing is the 1.7 release and retiring appveyor.

@linkerzhang
Copy link
Member

I'm merging it.

@chinhuang007 please kindly document this as part of your updated release experience, so that it will help the next release manager. Hopefully, we'll fix these issues before that though. :)

@linkerzhang linkerzhang merged commit 4cd2538 into onnx:master Mar 3, 2020
@chinhuang007
Copy link
Contributor

@linkerzhang Sure, I will certainly document the steps we are going through for 1.7 release. It should be smoother next time!

@snnn snnn deleted the rel-1.7.0 branch March 3, 2020 17:49
@chinhuang007
Copy link
Contributor

@snnn Thanks for providing the solution! I don't see anything in Actions for the release workflow, the workflow or the files. Do I need certain permissions?

@snnn
Copy link
Contributor Author

snnn commented Mar 3, 2020

Please try to create a rel-1.7.0 branch. The action only works on release branches.

@chinhuang007
Copy link
Contributor

@snnn Thanks for the explanation. I will create a rel-1.7.0 branch tomorrow and verify.

@chinhuang007
Copy link
Contributor

@snnn I created the release branch last night and saw the workflow in Actions. But I don't know where to find Windows wheels, as you shared in your branch. Please help clarify if I missed anything?

@snnn
Copy link
Contributor Author

snnn commented Mar 10, 2020

@chinhuang007
Copy link
Contributor

Thanks for providing the zip for Windows wheels. The next question is how can I generate and see the zip myself when something happens to the release branch (for ex. I am merging a couple of PRs from master to rel-1.7.0)? Should I also ask you to provide the file next time?

@snnn
Copy link
Contributor Author

snnn commented Mar 10, 2020

See:

image

@chinhuang007
Copy link
Contributor

Ah, somehow I didn't get to see this before. Thanks for pointing it out.

jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
* a

* Add ONNX_ML

* Update

* update

* a

* Revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants