-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a release pipeline for Windows python packages #2632
Conversation
This pull request introduces 1 alert when merging 6b73f09 into e8b33a5 - view on LGTM.com new alerts:
|
Just installed a wheel (win64 + py38) successfully. I think this should be included in release 1.7. |
Thank you so much! @snnn Quick questions: does this mean we'll need wheel-builder for Linux packages and this for windows packages? if yes, shall we put them in one place please? |
That will be better. But it will take me a few days more and I think currently the top priority thing is the 1.7 release and retiring appveyor. |
I'm merging it. @chinhuang007 please kindly document this as part of your updated release experience, so that it will help the next release manager. Hopefully, we'll fix these issues before that though. :) |
@linkerzhang Sure, I will certainly document the steps we are going through for 1.7 release. It should be smoother next time! |
@snnn Thanks for providing the solution! I don't see anything in Actions for the release workflow, the workflow or the files. Do I need certain permissions? |
Please try to create a rel-1.7.0 branch. The action only works on release branches. |
@snnn Thanks for the explanation. I will create a rel-1.7.0 branch tomorrow and verify. |
@snnn I created the release branch last night and saw the workflow in Actions. But I don't know where to find Windows wheels, as you shared in your branch. Please help clarify if I missed anything? |
Thanks for providing the zip for Windows wheels. The next question is how can I generate and see the zip myself when something happens to the release branch (for ex. I am merging a couple of PRs from master to rel-1.7.0)? Should I also ask you to provide the file next time? |
Ah, somehow I didn't get to see this before. Thanks for pointing it out. |
* a * Add ONNX_ML * Update * update * a * Revert
To replace https://github.com/onnx/wheel-builder
Sample run: https://github.com/snnn/onnx/actions/runs/47068032
You can download the wheels from there and try it.