Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print tensor dtypes as strings in shape inference #5856

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

isdanni
Copy link
Contributor

@isdanni isdanni commented Jan 14, 2024

Fix #5782

@isdanni isdanni requested a review from a team as a code owner January 14, 2024 23:07
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54e704e) 56.45% compared to head (a10cbd6) 56.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5856   +/-   ##
=======================================
  Coverage   56.45%   56.45%           
=======================================
  Files         504      504           
  Lines       29868    29868           
  Branches     4488     4488           
=======================================
  Hits        16863    16863           
  Misses      12188    12188           
  Partials      817      817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Contributor

Could you help update

"Mismatched tensor element type:", " inferred=", source_elem_type, " declared=", target_elem_type);
as well? Thanks!

@isdanni
Copy link
Contributor Author

isdanni commented Jan 16, 2024

Could you help update

"Mismatched tensor element type:", " inferred=", source_elem_type, " declared=", target_elem_type);

as well? Thanks!

updated! sorry I missed it first

Signed-off-by: isdanni <leedanni@gmail.com>
@justinchuby justinchuby added this pull request to the merge queue Jan 16, 2024
Merged via the queue into onnx:main with commit 463ca88 Jan 17, 2024
37 checks passed
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
Fix onnx#5782

Signed-off-by: isdanni <leedanni@gmail.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Print tensor dtypes as strings in shape inference
3 participants