fix problem of initializer not in input #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: daquexian <daquexian566@gmail.com>
daquexian
force-pushed
the
fix_high_ir
branch
from
0d0c762
to
ff3bbad
Compare
daquexian
changed the title
|
I think we should merge onnx/onnx#3007 |
|
@linkerzhang When will onnx/onnx#3007 be merged? If it will take a long time, this PR can serve as a temporary workaround. |
|
merge this firstly to unblock folks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since onnx/onnx#3007 cannot be merged in the short term, here is a naive workaround for onnx/onnx#2417: add the initializer to the input of the ModelProto, and remove them after optimization if needed. It follows the way of onnx-simplifier.
A test ("test_fuse_bn_into_conv_simple") is also updated for this case.