Fix issue #2102: Set reduction axis of mean to height and width for tf adjust_contrast op #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or adjust_contrast op Signed-off-by: cosine <cosine_chen@163.com>
fatcat-z
reviewed
Mar 20, 2023
| def func(x, y): | ||
| x_ = tf.image.adjust_contrast(x, y) | ||
| return tf.identity(x_, name=_TFOUTPUT) | ||
| self._run_test_case(func, [_OUTPUT], {_INPUT: x_val, _INPUT1: y_val}) | ||
| for x_shape in [[4, 3, 2], [2, 3, 4, 5], [3, 4, 2, 4, 3]]: |
There was a problem hiding this comment.
Is [3, 4, 2, 4, 3] a valid input for adjust_contrast() function? Ideally, the rank of image should be 4, right?
There was a problem hiding this comment.
It's a valid input. This function only requests input at least 3d, but doesn't require input to be 3d or 4d only.
https://www.tensorflow.org/api_docs/python/tf/image/adjust_contrast
fatcat-z
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/kernels/image/adjust_contrast_op.h