Fix CI and enable TKML to work with torch >= 2.2.0 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfowers
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
I don't really know what your code is doing so I'm gonna have to trust you here 😄
Does this resolve #84? Or that's still a problem (that possibly got worse)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
Issue
Torch recently released version 2.2.0, which broke TKML's CI pipeline.
The issue is caused by torch dynamo instrumenting callback functions, which conflicts with TKML's analysis and causes it to crash before TKML can report that only models in eager mode are supported.
Torch versions supported
This PR has been manually tested with both
torch 2.1.2andtorch 2.2.0. As a result, we can continue to assume that tkml works with the latest versions oftorch.