Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onAck delegation for Session #911

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

slavikbialik
Copy link
Contributor

@slavikbialik slavikbialik commented Feb 28, 2021

Added the ability to make an onAck session delegation, so we'll be able to catch when we are getting a SIP ACK from PBX side.
This helps to reduce race conditions, because currently the only way to detect when a call is REALLY being answered is to listen on the session state when it becomes SessionState.ESTABLISHED, usually it becomes ESTABLISHED before the ACK arrives. But waiting for ACK and acting accordingly is more reliable way.

Note: this is my first PR here, I hope it is done according to your guidelines (which I couldn't find).

@john-e-riordan
Copy link
Collaborator

john-e-riordan commented Mar 15, 2021

  • A request to end a {@link Session} (incoming ACK).

should be

  • A request to confirm a {@link Session} (incoming ACK).

Otherwise looks good to me. Thanks!

@slavikbialik
Copy link
Contributor Author

  • A request to end a {@link Session} (incoming ACK).

should be

  • A request to confirm a {@link Session} (incoming ACK).

Otherwise looks good to me. Thanks!

Fixed!
This is what happens when you copy-paste 😅

@slavikbialik
Copy link
Contributor Author

@john-e-riordan for some reason the CI failed as a result of a single test failure. Is there a way to make it re-run the tests without making any additional commit? Because the failed test should not fail because I just changed a comment 😓

@james-criscuolo james-criscuolo merged commit fd54a59 into onsip:master Mar 16, 2021
@james-criscuolo
Copy link
Collaborator

Thanks again! Not sure what's happening with Travis, we saw it elsewhere too, will have to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants