Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how Template adds entities to the QuotedEntityChecker #1104

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Mar 21, 2023

(Updated by @jamesaoverton)

Resolves #1133, resolves #1156.

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

Replaces private Template.addLabels() with Template.addEntities(): for each row in the template, make sure to add an entity to the QuotedEntityChecker (QEC). The previous version skipped rows without a LABEL. The new version adds both the label (if present) and the ID to the QEC. I believe this is backwards compatible.

I had problems with CI that seem unrelated, so I also dropped a test for subset extraction. See #1166.

@anitacaron
Copy link

It's not really a cycle but a sequence path.

@matentzn
Copy link
Contributor Author

I think the problem is that:

If there is no labels column,

Template.addLabels() never adds anything to the QuotedEntityChecker, which is needed to interpret curies in the ManchesterOWLSyntax parser. but I may be wrong.

@anitacaron
Copy link

Thank you, Nico! You said in Slack that adding column 'TYPE': 'TYPE' to the template solves the issue. I tried adding the label, and it didn't work, but adding the type Class worked well!

@matentzn
Copy link
Contributor Author

Thanks for confirming. It's still important for us to get to the bottom of this!

@jamesaoverton
Copy link
Member

Please reopen if you still want this PR.

Copy link
Contributor Author

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesaoverton looked through your changes, made some small comments for sanity checking but most likely everything is correct.

@jamesaoverton jamesaoverton marked this pull request as ready for review November 29, 2023 13:51
@jamesaoverton jamesaoverton changed the title This adds a failing test for the template cycle bug Fix how Template adds entities to the QuotedEntityChecker Nov 29, 2023
@jamesaoverton jamesaoverton merged commit 08b89af into master Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants