Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in onyx.plugin.s3-utils/list-keys #11

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

lcodes
Copy link
Contributor

@lcodes lcodes commented Sep 29, 2017

Hello!

We're starting to use the S3 plugin on buckets with large quantities of objects and noticed it doesn't handle truncated results correctly; the code keeps sending the same query over and over.

I also noticed there's a new V2 API to list S3 objects, but left the V1 implementation in place to keep the fix simple.

Now using a `ListObjectsRequest` object along with `getNextMarker` and
`setMarker` methods in order to properly handle truncated results.
@lbradstreet
Copy link
Member

lbradstreet commented Sep 30, 2017 via email

@lbradstreet lbradstreet changed the base branch from 0.11.x to master October 3, 2017 04:08
@lbradstreet lbradstreet merged commit b27de37 into onyx-platform:master Oct 3, 2017
@lbradstreet
Copy link
Member

Merged. Thank you! I've released0.11.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants