Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc metrics and logs #56

Merged
merged 13 commits into from
Feb 20, 2022

Conversation

findmyway
Copy link
Member

@findmyway findmyway commented Feb 18, 2022

  • Generate jl files from protos and manually merged them into one module
  • There used to be some misunderstanding of Views in MeterProvider, need revisit

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #56 (2bcdcd5) into master (78471e3) will decrease coverage by 2.30%.
The diff coverage is 72.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   82.87%   80.57%   -2.31%     
==========================================
  Files          46       45       -1     
  Lines        1057     1153      +96     
==========================================
+ Hits          876      929      +53     
- Misses        181      224      +43     
Impacted Files Coverage Δ
src/api/src/OpenTelemetryAPI.jl 100.00% <ø> (ø)
src/api/src/common/misc.jl 100.00% <ø> (ø)
src/exporter/otlp/proto/grpc/test/runtests.jl 100.00% <ø> (ø)
...ation/base/src/OpenTelemetryInstrumentationBase.jl 100.00% <ø> (ø)
src/sdk/src/OpenTelemetrySDK.jl 100.00% <ø> (ø)
src/sdk/src/metric/aggregation.jl 97.46% <ø> (+0.62%) ⬆️
...oto/grpc/src/OpenTelemetryExporterOtlpProtoGrpc.jl 48.73% <44.11%> (-5.11%) ⬇️
src/api/src/metric/metric_provider.jl 87.50% <80.00%> (-12.50%) ⬇️
src/sdk/src/metric/meter_provider.jl 80.28% <83.33%> (-3.31%) ⬇️
src/sdk/src/patch.jl 95.00% <95.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78471e3...2bcdcd5. Read the comment docs.

@findmyway findmyway merged commit cdcc64b into oolong-dev:master Feb 20, 2022
@findmyway findmyway mentioned this pull request Feb 20, 2022
25 tasks
@raffopazzo
Copy link

Was version 0.3.0 not published? It seems my Pkg.add() keeps installing 0.2.1

@findmyway
Copy link
Member Author

Oops. Yeah, I forgot to tag a new release. To make sure the latest code work as expected, I'll examine the main branch and then tag the new release this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants