Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-in v1: richer input for riseupvpn: discuss protoype #757

Closed
Tracked by #1291
bassosimone opened this issue Oct 23, 2023 · 1 comment
Closed
Tracked by #1291

check-in v1: richer input for riseupvpn: discuss protoype #757

bassosimone opened this issue Oct 23, 2023 · 1 comment
Assignees
Labels
api API discuss invites discussion from contributors funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/medium wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 23, 2023

Similar to #754, but for riseupvn. The main task here is not necessarily implementing and merging, rather discussing a prototype implementation and decide whether it would make sense to merge or whether it could tie our hands for the future. More specifically, consider the following:

  1. a minimal implementation of richer input for riseupvpn would just deliver the correct CA to probes (similarly to what we plan on doing for signal);

  2. probably we're going to be fine if we react to CA issues and update the CA (like we're doing for signal);

  3. however, it may be worth discussing also invoking the riseupvpn API to obtain endpoints to measure (which is more radical than just serving the correct CA but significantly contribute to make the experiment more dynamic);

  4. if we do that, we would probably need to have some service in the backend periodically calling riseup APIs.

My inclination is to split the work into two activities. The first activity is about just adding the correct-CA support and the second activity is about adding support for gathering endpoints. I'd like to discuss this plan with @ooni/ooni-team.

@bassosimone bassosimone added discuss invites discussion from contributors priority/medium funder/drl2022-2024 api API labels Oct 23, 2023
@bassosimone bassosimone self-assigned this Oct 23, 2023
@bassosimone bassosimone changed the title discuss: check-in v1: support richer input for riseupvpn check-in v1: support richer input for riseupvpn: discuss protoype Nov 21, 2023
@bassosimone bassosimone changed the title check-in v1: support richer input for riseupvpn: discuss protoype check-in v1: richer input for riseupvpn: discuss protoype Nov 21, 2023
@hellais hellais added the ooni/api Issues related to https://github.com/ooni/api label Mar 11, 2024
@bassosimone bassosimone added the wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case) label Jun 7, 2024
@bassosimone
Copy link
Contributor Author

As discussed in ooni/probe-cli#1621 and considering previous conversations with Arturo and given the work he's been doing to divide the backend in tiers, it's not critical anymore to discuss a prototype and we can just follow the new pattern of having a microservice for serving this kind of richer input (or a pool of related inputs that are all deemed not P0) without the need to have extensive discussions. Yay for the tier architecture!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API discuss invites discussion from contributors funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/medium wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)
Projects
None yet
Development

No branches or pull requests

2 participants