Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

richer input: support dnscheck #754

Open
Tracked by #1291
bassosimone opened this issue Oct 23, 2023 · 0 comments
Open
Tracked by #1291

richer input: support dnscheck #754

bassosimone opened this issue Oct 23, 2023 · 0 comments
Assignees
@bassosimone
Labels
api API enhancement improving existing code or new feature funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/high

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 23, 2023 •
edited
Loading

Consistently with the plan at ooni/ooni.org#1295 (comment), we originally wanted to extend check-in v1 to deliver dnscheck richer input to OONI Probe clients. As of 2024-06-07, there has been a change of plans, thanks to the new layered backend architecture, which means we can have a specific microservice rather than modifying the check-in API.
@bassosimone bassosimone added the enhancement improving existing code or new feature label Oct 23, 2023
@bassosimone bassosimone self-assigned this Oct 23, 2023
@bassosimone bassosimone mentioned this issue Oct 23, 2023
Closed
This was referenced Oct 23, 2023
Open
Open
Closed
Open
Closed
Closed
This was referenced Nov 21, 2023
Closed
Open
@hellais hellais added the ooni/api Issues related to https://github.com/ooni/api label Mar 11, 2024
@bassosimone bassosimone changed the title check-in v1: support richer input for dnscheck richer input: support dnscheck Jun 7, 2024
@bassosimone bassosimone mentioned this issue Jun 25, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Jun 25, 2024
@bassosimone
refactor(probeservices): use better naming (#1628)
65df439 
Calling the endpoint base URL (e.g., `https://www.example.com/`)
"endpoint" could cause confusion because usually an API endpoint is
something like `https://www.example.com/api/v1/check-in`. To obviate
this semantic issue, this diff attempts to avoid calling base URLs as
endpoint throughout the tree.

I am going to account this work as part of
ooni/backend#754 because this is one of the
possibly issues on which we can account this work. The original
conversation with @ainghazal, which prodded me to make these changes,
was related to his feedback after implementing
#1625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
api API enhancement improving existing code or new feature funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bassosimone @hellais @DecFox