Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-in v1: richer input for urlgetter: discuss prototype #759

Closed
Tracked by #1291
bassosimone opened this issue Oct 23, 2023 · 1 comment
Closed
Tracked by #1291

check-in v1: richer input for urlgetter: discuss prototype #759

bassosimone opened this issue Oct 23, 2023 · 1 comment
Assignees
Labels
api API enhancement improving existing code or new feature funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/medium wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 23, 2023

Similar to #754, but for urlgetter. The main task here is not necessarily implementing and merging, rather discussing a prototype implementation and decide whether it would make sense to merge or whether it could tie our hands for the future. More specifically, consider the following:

  1. if we define richer input like we plan on doing for dnscheck (see also the plan at Write a design document for how to support richer testing input ooni.org#1295), we can support a wide array of urlgetter based experiments;

  2. however, doing that could be binding because we never defined what urlgetter options are supported in the long run;

I would like to discuss with @ooni/ooni-team which options we want to support and whether there is a way for us to be even more flexible with respect to richer input as far as the urlgetter experiment is concerned.

@bassosimone bassosimone added enhancement improving existing code or new feature ooni/api Issues related to https://github.com/ooni/api priority/medium funder/drl2022-2024 api API labels Oct 23, 2023
@bassosimone bassosimone self-assigned this Oct 23, 2023
@bassosimone bassosimone changed the title discuss: check-in v1: support richer input for urlgetter discuss: check-in v1: support richer input for urlgetter Nov 21, 2023
@bassosimone bassosimone changed the title discuss: check-in v1: support richer input for urlgetter check-in v1: support richer input for urlgetter: discuss prototype Nov 21, 2023
@bassosimone bassosimone changed the title check-in v1: support richer input for urlgetter: discuss prototype check-in v1: richer input for urlgetter: discuss prototype Nov 21, 2023
@bassosimone bassosimone added the wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case) label Jun 7, 2024
@bassosimone
Copy link
Contributor Author

As discussed in ooni/probe-cli#1621 and considering previous conversations with Arturo and given the work he's been doing to divide the backend in tiers, it's not critical anymore to discuss a prototype and we can just follow the new pattern of having a microservice for serving this kind of richer input (or a pool of related inputs that are all deemed not P0) without the need to have extensive discussions. Yay for the tier architecture!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API enhancement improving existing code or new feature funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/medium wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)
Projects
None yet
Development

No branches or pull requests

1 participant