2024 refactor part 3/3: cleanup #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellais
force-pushed
the
2024-refactor_cleanup
branch
2 times, most recently
from
872ec30
to
db91e6d
Compare
Closed
bassosimone
reviewed
Feb 5, 2024
bassosimone
reviewed
Feb 5, 2024
bassosimone
reviewed
Feb 5, 2024
| app.extensions["limiter"] = self | ||
|
|
||
| def get_lowest_daily_quotas_summary(self, n=20) -> List[Tuple[int, float]]: | ||
| return self._limiter.get_lowest_daily_quotas_summary(n) |
There was a problem hiding this comment.
This file was a duplicate
| @@ -1,2 +0,0 @@ | |||
| lz4cat meta-closure.sql.lz4 | psql -U postgres -h localhost -p 5433 measurements -f sample-dump.sql | |||
|
|
|||
There was a problem hiding this comment.
What does refresh this script?
There was a problem hiding this comment.
I don't understand the question.
There was a problem hiding this comment.
Neither do I, it was phrased incorrectly. I mean to ask:
What does replace this script?
There was a problem hiding this comment.
No idea, probably nothing.
This commit should be reverted prior to merge (see 🔄 emoji 🙃)
Co-authored-by: Simone Basso <bassosimone@gmail.com>
hellais
force-pushed
the
2024-refactor_cleanup
branch
from
0cdde89
to
145e088
Compare
Co-authored-by: Simone Basso <bassosimone@gmail.com>
…2024-refactor_cleanup * '2024-refactor_cleanup' of github.com:ooni/backend: Update README.md
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3/3
As part of this PR, everything that is dead code, is removed from the source tree.
This includes:
af/-> this was the old airflow postgresql related codeold_backend/-> this was the super old pre-2016 twisted based backenddocs/-> contained documentation about the ~2016 data pipelineReadme.md-> Still talks about some super old stuffrate_limit_quotas.py-> duplicate of file inside ooniapi/rate_limit_quotas.pyooniapi/scripts-> these scripts expect a postgresql database, which doesn't exist anymoreapi/refresh_deps-> non-existent files are referenced in itmarkdown/*-> these docs are not used anywhere and are superseeded by the swagger based docsSuperseeds:
#797
#798
#791