Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/5.0.0 alpha3 #81

Merged
merged 44 commits into from
Aug 23, 2024
Merged

Release/5.0.0 alpha3 #81

merged 44 commits into from
Aug 23, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Aug 2, 2024

Changes:

  • Switch to threaded workers via co-routines
  • Get rid of unused commands
  • Remove unused and dead code
  • Update assets from s3 instead of archive.org
  • Get rid of file based locking for asset updates
  • Add alter queries for buffer tables in DB migration helper

Fixes:

  • Fix bug in database migration generation
  • Issues related to setting workflow and schedule IDs to facilitate re-running backfills
  • Properly set the transaction_id for more modern tests that support it (eg. web_connectivity 0.5)

Changes:
* Switch to threaded workers via co-routines
* Get rid of unused commands
* Fix bug in database migration generation
* Remove unused and dead code
Get read of file based locking
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 69.05830% with 69 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (5eb8617) to head (1fe5a38).
Report is 1 commits behind head on main.

Files Patch % Lines
...onipipeline/src/oonipipeline/temporal/workflows.py 65.90% 15 Missing ⚠️
oonipipeline/src/oonipipeline/db/create_tables.py 50.00% 13 Missing ⚠️
oonipipeline/src/oonipipeline/temporal/workers.py 43.47% 13 Missing ⚠️
oonipipeline/src/oonipipeline/netinfo.py 36.84% 12 Missing ⚠️
...oonipipeline/transforms/measurement_transformer.py 40.00% 6 Missing ⚠️
oonipipeline/src/oonipipeline/cli/commands.py 58.33% 5 Missing ⚠️
...ine/src/oonipipeline/temporal/client_operations.py 80.00% 2 Missing ⚠️
...ine/src/oonipipeline/temporal/activities/common.py 50.00% 1 Missing ⚠️
.../oonipipeline/temporal/activities/ground_truths.py 66.66% 1 Missing ⚠️
oonipipeline/tests/conftest.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   83.03%   82.86%   -0.18%     
==========================================
  Files          75       75              
  Lines        6295     6267      -28     
==========================================
- Hits         5227     5193      -34     
- Misses       1068     1074       +6     
Flag Coverage Δ
oonidata 77.41% <ø> (ø)
oonipipeline 85.25% <69.05%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ase/5.0.0-alpha3

* 'release/5.0.0-alpha3' of github.com:ooni/data:
  Add .DS_Store to ignore
  Switch tests back to hatch run cov
@hellais hellais mentioned this pull request Aug 23, 2024
3 tasks
@hellais
Copy link
Member Author

hellais commented Aug 23, 2024

I am going to land this and proceed with future work as part of new PRs

@hellais hellais merged commit 2d54c38 into main Aug 23, 2024
8 of 9 checks passed
@hellais hellais deleted the release/5.0.0-alpha3 branch August 23, 2024 08:41
hellais added a commit that referenced this pull request Aug 30, 2024
* v5.0.0-rc.0:
  Add simple redirector
  Tidy up the layout of the analysis viewer
  Add an observations viewer
  Get rid of all the dataviz that isn't the analysis visualizer
  Release/5.0.0 alpha3 (#81)
  Offset analysis schedule by 6 hours
  Add support for temporal cloud (#79)
  fix: support for sorting network_events using transaction_id (#51)
  Optimize performance of table writers and refactor table model (#74)
  Improvements related to deployment (#69)
  Add .codecov file
  Update jsonl sync example
  Setup workflow to publish ooni data docs (#73)
  OONI Pipeline v5 alpha (#64)
  Fix codecov (#62)
  Temporal workflows (#61)
  OONI Data, OONI Pipeline split (#60)
  Add support for caching netinfodb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant