Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add documentation to the layered architecture #56

Merged
merged 110 commits into from
Jan 24, 2024
Merged

refactor: add documentation to the layered architecture #56

merged 110 commits into from
Jan 24, 2024

Commits on May 8, 2023

  1. feat(reliable): minimal reliability layer implementation 

    I've tried to achieve te minimal incremental change that adds resilience
in the face of network noise.

To achieve that, the simple thing to do was to make session an object
owned by an implementation of reliableTransport. I've reused the
reliableUDP implementation in govpn, and I like the simplicity of that
implementation a lot. A lot of our current logic (ackqueue/retries)
needed to move from the tlsTransport minivpn implementation into
reliableTransport.

Although the DoS documented in the MIV-01 report is not done, we add the
e2e testing script to facilitate further development.

- Related: ooni#32

more tests
    @ainghazal
    ainghazal committed May 8, 2023
    Configuration menu
    Copy the full SHA
    ace9fa4 View commit details
    Browse the repository at this point in the history

  2. docs: add architecture diagram

    @ainghazal
    ainghazal committed May 8, 2023
    Configuration menu
    Copy the full SHA
    6a372b2 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. reorder methods

    @ainghazal
    ainghazal committed May 9, 2023
    Configuration menu
    Copy the full SHA
    ebf6461 View commit details
    Browse the repository at this point in the history

  2. go mod tidy

    @ainghazal
    ainghazal committed May 9, 2023
    Configuration menu
    Copy the full SHA
    8cf23f1 View commit details
    Browse the repository at this point in the history

  3. add sbs code

    @ainghazal
    ainghazal committed May 9, 2023
    Configuration menu
    Copy the full SHA
    16bd608 View commit details
    Browse the repository at this point in the history

  4. simplify tls

    @ainghazal
    ainghazal committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a35990b View commit details
    Browse the repository at this point in the history

  5. leave notes

    @ainghazal
    ainghazal committed May 9, 2023
    Configuration menu
    Copy the full SHA
    cfcd41f View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. wip: proxyconn usage

    @ainghazal
    ainghazal committed May 10, 2023
    Configuration menu
    Copy the full SHA
    18785b7 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. feat: start sketching out channel-based design 

    Discussed with @ainghazal extensively.
    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a781108 View commit details
    Browse the repository at this point in the history

  2. "I think you also want to commit the .editorconfig"

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    52a1e25 View commit details
    Browse the repository at this point in the history

  3. chore: publish implements that @ainghazal will build upon

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    41a939c View commit details
    Browse the repository at this point in the history

  4. feat: wire-in all the services 

    In particular, make sure it's ~easy to connect them all.
    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c10f815 View commit details
    Browse the repository at this point in the history

  5. start refactor on datachannel

    @ainghazal
    ainghazal committed May 12, 2023
    Configuration menu
    Copy the full SHA
    dce5dc8 View commit details
    Browse the repository at this point in the history

  6. more refactor on datachannel

    @ainghazal
    ainghazal committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0e8f9d5 View commit details
    Browse the repository at this point in the history

  7. more refactor on datachannel

    @ainghazal
    ainghazal committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1b28a27 View commit details
    Browse the repository at this point in the history

  8. remove old session

    @ainghazal
    ainghazal committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ea082f4 View commit details
    Browse the repository at this point in the history

  9. keysource defined in source module

    @ainghazal
    ainghazal committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0bc1f87 View commit details
    Browse the repository at this point in the history

  10. workers manager adaptations

    @ainghazal
    ainghazal committed May 12, 2023
    Configuration menu
    Copy the full SHA
    27b1835 View commit details
    Browse the repository at this point in the history

  11. feat: start trying to handshake

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a38a35c View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'ainghazal/channels' into channels

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    31218ca View commit details
    Browse the repository at this point in the history

  13. chore: push the current code

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4fda4b1 View commit details
    Browse the repository at this point in the history

  14. checkpoint: we can do the three way OpenVPN handshake

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    afc9fc9 View commit details
    Browse the repository at this point in the history

  15. more changes

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    df6da04 View commit details
    Browse the repository at this point in the history

  16. feat: we finally have TLS handshake working

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    6d89142 View commit details
    Browse the repository at this point in the history

  17. we can now do the whole bootstrap

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    42d7240 View commit details
    Browse the repository at this point in the history

  18. chore: add the architecture diagram

    @bassosimone
    bassosimone committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f8e11d2 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. feat: tentatively pass the keys to one of the data channel workers

    @bassosimone
    bassosimone committed May 13, 2023
    Configuration menu
    Copy the full SHA
    4deefc3 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. fix peer-id

    @ainghazal
    ainghazal committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    139d610 View commit details
    Browse the repository at this point in the history

  2. wip datachannel

    @ainghazal
    ainghazal committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    201320c View commit details
    Browse the repository at this point in the history

  3. minor: change logging label

    @ainghazal
    ainghazal committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    296c52b View commit details
    Browse the repository at this point in the history

  4. checkpoint: keys generated

    @ainghazal
    ainghazal committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    37f4fd8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. wip: data channel encrypt/decrypt

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a8285fb View commit details
    Browse the repository at this point in the history

  2. wip: data channel encrypt/decrypt

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    96fd0bb View commit details
    Browse the repository at this point in the history

  3. wip: pass tunnelInfo to tun

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    aedc258 View commit details
    Browse the repository at this point in the history

  4. ignore more things

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    fdc46e0 View commit details
    Browse the repository at this point in the history

  5. go mod tidy

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5860f57 View commit details
    Browse the repository at this point in the history

  6. wip: write to tun

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    32dc7e3 View commit details
    Browse the repository at this point in the history

  7. wip: checkpoint: receive ping reply

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    dc2746e View commit details
    Browse the repository at this point in the history

  8. wip: debug incoming ping responses

    @ainghazal
    ainghazal committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3617ed8 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. checkpoint: ping finishes

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    25844ac View commit details
    Browse the repository at this point in the history

  2. checkpoint: ping finishes and closes the connection

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    75b173c View commit details
    Browse the repository at this point in the history

  3. added a tun interface

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9f9ca66 View commit details
    Browse the repository at this point in the history

  4. add route for endpoint via default gateway

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    99ce0d5 View commit details
    Browse the repository at this point in the history

  5. rename

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3bdcea9 View commit details
    Browse the repository at this point in the history

  6. wip: rename channels for consistency

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    50c4e8f View commit details
    Browse the repository at this point in the history

  7. wip: rename channels for consistency

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5f3c1b3 View commit details
    Browse the repository at this point in the history

  8. wip: rename channels for consistency

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    15c8ced View commit details
    Browse the repository at this point in the history

  9. wip: rename channels for consistency

    @ainghazal
    ainghazal committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    8aea08b View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. update architecture diagram

    @ainghazal
    ainghazal committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    fe33650 View commit details
    Browse the repository at this point in the history

  2. revert vpn tree to main

    @ainghazal
    ainghazal committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    42e98a5 View commit details
    Browse the repository at this point in the history

  3. simplify vpnping command

    @ainghazal
    ainghazal committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    263ef6f View commit details
    Browse the repository at this point in the history

  4. resolve conflicts

    @ainghazal
    ainghazal committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    66b857f View commit details
    Browse the repository at this point in the history

  5. bump go version used

    @ainghazal
    ainghazal committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c137ab9 View commit details
    Browse the repository at this point in the history

  6. stick to go1.20

    @ainghazal
    ainghazal committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c2bea87 View commit details
    Browse the repository at this point in the history

  7. assign directly

    @ainghazal
    ainghazal committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    282bc17 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge branch 'main' into refactor-baseline 

    merging after refactor-packetmuxer has been merged
    @ainghazal
    ainghazal committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2b570ee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-baseline

    @ainghazal
    ainghazal committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    877200c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-baseline

    @ainghazal
    ainghazal committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e7ec342 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'main' into refactor-baseline

    @ainghazal
    ainghazal committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a7b5305 View commit details
    Browse the repository at this point in the history

  2. tlsstate has been renamed

    @ainghazal
    ainghazal committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b95b062 View commit details
    Browse the repository at this point in the history

  3. add documentation

    @ainghazal
    ainghazal committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    db138ae View commit details
    Browse the repository at this point in the history

  4. add more comments

    @ainghazal
    ainghazal committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ac41e3d View commit details
    Browse the repository at this point in the history

  5. Update internal/tun/setup.go 

    Co-authored-by: Simone Basso <bassosimone@gmail.com>
    @ainghazal @bassosimone
    ainghazal and bassosimone authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    5a7f44d View commit details
    Browse the repository at this point in the history

  6. x

    @ainghazal
    ainghazal committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f03117d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into refactor-tun

    @ainghazal
    ainghazal committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0371a9b View commit details
    Browse the repository at this point in the history

  8. Update internal/tun/tun.go

    @bassosimone
    bassosimone authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b489fec View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. adapt tun deadline

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2ba5092 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactor-tun' into refactor-baseline

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6a6b81b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-baseline

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    64d3de0 View commit details
    Browse the repository at this point in the history

  4. adapt starttun

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6213e7b View commit details
    Browse the repository at this point in the history

  5. feat: track the netmask passed by the remote 

    this is needed to configure routes for the tun interface.
    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5f473c0 View commit details
    Browse the repository at this point in the history

  6. setup routes

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c8bc9cc View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into refactor-baseline

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8e95bdf View commit details
    Browse the repository at this point in the history

  8. refactor: parametrize logging in workers start/end

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0b53eac View commit details
    Browse the repository at this point in the history

  9. commit architecture asciiflow diagram

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    98a1532 View commit details
    Browse the repository at this point in the history

  10. iterate on diagram

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2381525 View commit details
    Browse the repository at this point in the history

  11. iterate on diagram

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e033668 View commit details
    Browse the repository at this point in the history

  12. iterate on diagram

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0b5d5a3 View commit details
    Browse the repository at this point in the history

  13. include excalidraw file

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1d12891 View commit details
    Browse the repository at this point in the history

  14. refactor: parametrize logging in workers start/end

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8ccf493 View commit details
    Browse the repository at this point in the history

  15. x

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bfc4e53 View commit details
    Browse the repository at this point in the history

  16. add todos

    @ainghazal
    ainghazal committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fca1080 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Update ARCHITECTURE.md

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5f95699 View commit details
    Browse the repository at this point in the history

  2. go mod tidy

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7a93b01 View commit details
    Browse the repository at this point in the history

  3. ignore openvpn

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d9a3003 View commit details
    Browse the repository at this point in the history

  4. wip integration

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ef28d31 View commit details
    Browse the repository at this point in the history

  5. add channels diagram

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1902b92 View commit details
    Browse the repository at this point in the history

  6. Merge commit 'ef28d31' into architecture-review

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6ed66ea View commit details
    Browse the repository at this point in the history

  7. revert ping

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    adc2adb View commit details
    Browse the repository at this point in the history

  8. revert mod tidy

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1b0c724 View commit details
    Browse the repository at this point in the history

  9. not this diagram

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    10ddea5 View commit details
    Browse the repository at this point in the history

  10. remove excalidraw for now

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    55953e0 View commit details
    Browse the repository at this point in the history

  11. fix merge conflict

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5adbc14 View commit details
    Browse the repository at this point in the history

  12. update packetmuxer comments

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    51e473a View commit details
    Browse the repository at this point in the history

  13. update architecture

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d2fe46c View commit details
    Browse the repository at this point in the history

  14. update architecture

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6492dc5 View commit details
    Browse the repository at this point in the history

  15. update architecture

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e1c2636 View commit details
    Browse the repository at this point in the history

  16. improve diagram

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ad38bef View commit details
    Browse the repository at this point in the history

  17. update diagram, all channels represented

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    fcc4752 View commit details
    Browse the repository at this point in the history

  18. be more verbose

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8a25d27 View commit details
    Browse the repository at this point in the history

  19. x

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cd13f4c View commit details
    Browse the repository at this point in the history

  20. add pull request template

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d1689aa View commit details
    Browse the repository at this point in the history

  21. x

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0df72d4 View commit details
    Browse the repository at this point in the history

  22. default TLS timeout

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    49f8b4d View commit details
    Browse the repository at this point in the history

  23. x

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b60bf9d View commit details
    Browse the repository at this point in the history

  24. x

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5864842 View commit details
    Browse the repository at this point in the history

  25. add comment

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6f1f1bb View commit details
    Browse the repository at this point in the history

  26. typo

    @ainghazal
    ainghazal committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    43a0222 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Update internal/networkio/service.go 

    Co-authored-by: Simone Basso <bassosimone@gmail.com>
    @ainghazal @bassosimone
    ainghazal and bassosimone authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    317a29e View commit details
    Browse the repository at this point in the history

  2. re-add comment

    @ainghazal
    ainghazal committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0c2c439 View commit details
    Browse the repository at this point in the history