Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to the translations to the original files #1364

Merged
merged 9 commits into from
Mar 22, 2023

Conversation

sloncocs
Copy link
Contributor

  • make sure that outreach happens
  • when merging, double check that the publication date is today

@sloncocs sloncocs added documentation Improvements or additions to documentation translation labels Mar 22, 2023
@sloncocs sloncocs requested a review from agrabeli March 22, 2023 11:17
@sloncocs sloncocs self-assigned this Mar 22, 2023
Copy link
Member

@agrabeli agrabeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @sloncocs!

My only feedback is that there's some inconsistency, with some languages written in the original language, while others (Arabic and Farsi) in English.

For example:

Español, Riesgos: Lo que debes saber antes de ejecutar OONI Probe
Arabic, Risks: Things you should know before running OONI Probe
Farsi, Risks: Things you should know before running OONI Probe
Kiswahili, Hatari: Vitu unavyotakiwa kuvijua kabla ya kutumia OONI Probe
Русский, Риски: что вы должны знать до запуска OONI Probe

Would it be possible to have the words Arabic and Farsi, and the associated document titles, in their respective languages? Or is there an RTL-related challenge?

Otherwise, we could either have all language names in English, or keep it as is for now.

@sloncocs
Copy link
Contributor Author

Thank you @agrabeli!

We cannot add the full titles because they won't be readable in LTR text. I changed the language names to العربية and فارسی.

@agrabeli agrabeli merged commit a82d79c into ooni:master Mar 22, 2023
@sloncocs sloncocs deleted the translations-referencing branch April 3, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants