Add CircleCI based package build #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoCeratto
force-pushed
the
circleci
branch
from
dbf1623
to
232d503
Compare
hellais
reviewed
Nov 21, 2019
| mv ../*.deb /tmp/debs/ | ||
| pname="fastpath" | ||
| fn=${pname}_${ver}_all.deb | ||
| curl --show-error -f -T /tmp/debs/$fn -u$BTUSER:$BINTRAY_API_KEY "https://api.bintray.com/content/ooni/internal-pull-requests/${pname}/${ver}/${fn};deb_distribution=unstable;deb_component=main;deb_architecture=amd64;publish=1" |
There was a problem hiding this comment.
Maybe we can split this long line to be a bit more readable?
hellais
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
I just left a minor comment, but this looks good to merge to me.
Once you land it can you also update https://github.com/ooni/sysadmin/pull/380/files to do the required setup to install the deb package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package built and published at https://dl.bintray.com/ooni/internal-pull-requests/
This is an experiment related to https://github.com/ooni/sysadmin/issues/381
The package build + upload into bintray takes approx 1 minute