[New Designs] Implement Dashboard Link update loading and Review Updates #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add a `ViewModel` for state management
…ndroid into issues/2591
…dle-kotlin-upgrade
…actActivity.java Co-authored-by: Simone Basso <bassosimone@gmail.com>
…ctivity.java Co-authored-by: Simone Basso <bassosimone@gmail.com>
…ctivity.java Co-authored-by: Simone Basso <bassosimone@gmail.com>
…ctivity.java Co-authored-by: Simone Basso <bassosimone@gmail.com>
…iewActivity.java Co-authored-by: Simone Basso <bassosimone@gmail.com>
…iewActivity.java Co-authored-by: Simone Basso <bassosimone@gmail.com>
## Proposed Changes - Add supported icons in project and track.
…#653) Fixes # <issue> ## Proposed Changes - Adds uninstall button - Adds setting for auto-update - Updates preferences to properly save autorun settings
Base automatically changed from
issues/2595-uninstall-and-auto-update
to
issues/2595
February 13, 2024 14:13
…erent screen (#657) ## Proposed Changes - Add `OoniRunV2Activity` to handle all incoming OONI Run v2 `Intents` - Update `AndroidManifest.xml` to launch `OoniRunV2Activity` when OONI Run v2 `Intents` are received. - Clean `MainActivity` - Override `onBackPressed` and `finish` in `AddDescriptorActivity` to ensure activity always launches `MainActivity` when closed |.| Possible Areas of Improvement | |-|-| | | -Improve on error messages. <br/> - Merge with `AddDescriptorActivity` to make a single activity with 2 fragments for each of the views (requires a bit of core rewrite). | --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
…en fetching preferences in `RunTestsActivity`
## Proposed Changes - Check if `worker` has started before actually displaying progress. - Add color to `AddDescriptorActivity` icon - End `OoniRunV2Activity` when descriptor cannot be fetched. - Update `InstalledDescriptor` to use preference prefix properly.
bassosimone
reviewed
Mar 21, 2024
| descriptor.runId, | ||
| applicationContext | ||
| ) | ||
| /** |
There was a problem hiding this comment.
AFAIK, JavaDoc comments only have effect when documenting classes and methods. Did I got this incorrectly? Is this comment rendered in the documentation? If not, maybe I'd avoid using JavaDoc inside methods.
bassosimone
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ooni/probe#2594
Proposed Changes
descriptorswithautoUpdateenabled every 24 hrs.descriptorswithautoUpdatedisabled and return to caller.autoUpdatedisabled inMainActivity