feat: Update the entry point for ooni run v2 to use load using a different screen#657
Conversation
…oni/probe-android into issues/2595-loading-screen-entry-point
…es `MainActivity` when closed
|
We should take care of this failure in There is also this error in |
bassosimone
left a comment
There was a problem hiding this comment.
🐳 with request to apply minor changes and to fix broken tests
| * A v2 link has the following format: | ||
| * | ||
| * 1. ooni://runv2/link_id | ||
| * 2. https://run.test.ooni.org/v2/link_id |
There was a problem hiding this comment.
Do we anticipate to always support run.test or are we going to switch to only run.ooni.org in the future? In the former case, I'd proactively document both; in the latter I'd just document run.ooni.org.
There was a problem hiding this comment.
This has not been discussed int the past. the final resting domain for OONI Run V2 has not been discussed. I am not sure at the moment what it would be changed to in the future.
| activityComponent.inject(this) | ||
| binding = ActivityOoniRunV2Binding.inflate(layoutInflater) | ||
| setContentView(binding.root) | ||
| onNewIntent(intent) |
There was a problem hiding this comment.
Where is intent declared?
There was a problem hiding this comment.
Intent is declared in the activity that it inherits.
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
…un/OoniRunV2Activity.kt Co-authored-by: Simone Basso <bassosimone@gmail.com>
Proposed Changes
OoniRunV2Activityto handle all incoming OONI Run v2IntentsAndroidManifest.xmlto launchOoniRunV2Activitywhen OONI Run v2Intentsare received.MainActivityonBackPressedandfinishinAddDescriptorActivityto ensure activity always launchesMainActivitywhen closed- Merge with
AddDescriptorActivityto make a single activity with 2 fragments for each of the views (requires a bit of core rewrite).