This repository was archived by the owner on Apr 20, 2026. It is now read-only.
Feat: Add Icon support for OONI Run v2 descriptors#649
Merged
aanorbel merged 12 commits intoissues/2595from Feb 13, 2024
Merged
Feat: Add Icon support for OONI Run v2 descriptors#649aanorbel merged 12 commits intoissues/2595from
aanorbel merged 12 commits intoissues/2595from
Conversation
…es/2595-database-actions
…es/2595-database-actions
Member
Author
|
Here is an analysis on the file size on the addition of icons to the application. |
bassosimone
reviewed
Jan 12, 2024
Comment on lines
89
to
90
| /* TODO(aanorbel): Update to parse the icon name and set the correct icon. | ||
| * Remember to ignore icons generated when generated doing this.*/ |
Contributor
There was a problem hiding this comment.
do we need to keep or update this comment?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes