Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial packaging #117

Merged
merged 18 commits into from
Nov 13, 2020
Merged

Initial packaging #117

merged 18 commits into from
Nov 13, 2020

Conversation

FedericoCeratto
Copy link
Contributor

Set Travis to use Bionic
Create a simple Debian package
Do not upload into bintray yet

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except a couple of places for which I asked questions.

debian/changelog Outdated Show resolved Hide resolved
debian/ooniprobe-cli.install Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
debian/control Outdated Show resolved Hide resolved
debian/control Outdated Show resolved Hide resolved
debian/control Show resolved Hide resolved
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments throughout. I think it's a great first iteration.

We can even land it once the comments are addressed.

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FedericoCeratto! You did an awesome job here and I am very excited that now we have a working Debian package that we can soon sponsor to people! 🐳

@bassosimone
Copy link
Contributor

For the records:

# cat /etc/apt/sources.list.d/ooni.list 
deb [trusted=yes] https://dl.bintray.com/ooni/ooniprobe-debian/ unstable main

@bassosimone bassosimone merged commit 6df2c34 into master Nov 13, 2020
@bassosimone bassosimone deleted the packaging branch November 13, 2020 08:59
ainghazal pushed a commit to ainghazal/probe-cli that referenced this pull request Mar 8, 2022
* Add initial packaging

* Update Vcs URLs

* Disable test

* Update dh version

* Switch to ubuntu-20.04

* Add d/compat

* Update install

* Find file

* Update location

* Upload to bintray

* Add version

* Add dep

* Set vars

* Drop file

* Update Readme.md

* Update linux-debian-packages.yml

* Update linux-debian-packages.yml

Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants