ooni.go: use 32 bit counter to signal interruption #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a 64 bit counter has pitfalls. See Go documentation. I don't want a refactoring or whatever to let these pitfalls emerge in the future. We just need one bit to signal we're done. So use 32 bit, which shall be safe everywhere. See https://golang.org/pkg/sync/atomic/#pkg-note-BUG. Proactively triggered by ooni/probe-engine#399.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
Using a 64 bit counter has pitfalls. See Go documentation. I don't want a refactoring or whatever to let these pitfalls emerge in the future. We just need one bit to signal we're done. So use 32 bit, which shall be safe everywhere. See https://golang.org/pkg/sync/atomic/#pkg-note-BUG. Proactively triggered by ooni/probe-engine#399.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a 64 bit counter has pitfalls. See Go documentation.
I don't want a refactoring or whatever to let these pitfalls
emerge in the future.
We just need one bit to signal we're done.
So use 32 bit, which shall be safe everywhere.
See https://golang.org/pkg/sync/atomic/#pkg-note-BUG.
Proactively triggered by ooni/probe-engine#399.