refactor(netxlite): use *Netx for the system resolver #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code modifies how we construct netxlite's system resolver such that public functions use the *Netx equivalents. The general idea for which I am pushing here is to have additional clarity about dependencies, to better analyze the requirements of non measuring code for ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff modifies how we construct netxlite's system resolver such that public functions use the *Netx equivalents. While there, recognize that there wasn't enough testing for the optional wrappers provided by `model.DNSTransportWrapper` and that we are not using this functionality. So, rather than writing new tests for this functionality, we can actually just drop it and simplify the codebase. While there, recognize that `netxlite.WrapDNSTransport` could easily become private. While there, recognize that `./legacy/netx` needs lots of public function being exported by `netxlite` but we don't need to expose that many implementation details to new code that will be using `*Netx`. So, make sure all the new methods we create for `*Netx` are actually private methods. (Ideally, the API surface of `netxlite` should be smaller; we would not be able to get there for quite some time, but we can at least avoid increasing the API surface.) The general idea for which I am pushing here is to have additional clarity about dependencies, to better analyze the requirements of non measuring code for ooni/probe#2531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff modifies how we construct netxlite's system resolver such that public functions use the *Netx equivalents.
While there, recognize that there wasn't enough testing for the optional wrappers provided by
model.DNSTransportWrapperand that we are not using this functionality. So, rather than writing new tests for this functionality, we can actually just drop it and simplify the codebase.While there, recognize that
netxlite.WrapDNSTransportcould easily become private.While there, recognize that
./legacy/netxneeds lots of public function being exported bynetxlitebut we don't need to expose that many implementation details to new code that will be using*Netx. So, make sure all the new methods we create for*Netxare actually private methods. (Ideally, the API surface ofnetxliteshould be smaller; we would not be able to get there for quite some time, but we can at least avoid increasing the API surface.)The general idea for which I am pushing here is to have additional clarity about dependencies, to better analyze the requirements of non measuring code for ooni/probe#2531.