feat(netxlite): use *Netx for NewParallelUDPResolver #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overall idea at this point is that we will have an interface containing the methods we currently have inside *Netx and we will sever the hard dependency between measurexlite and netxlite. We will probably still need to import some contants from netxlite but, for all effects and purposes, measurexlite would become completely mockable (as it is now) with an explicit dependency on the related behavior. In turn, this refactoring would clarify which netxlite functionality we use for measuring, which are legacy, and which we use for communicating with the OONI backend. That change would definitely make it obvious to modify netxlite and go in the overall direction defined by ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
The overall idea at this point is that we will have an interface containing the methods we currently have inside *Netx and we will sever the hard dependency between measurexlite and netxlite. We will probably still need to import some contants from netxlite but, for all effects and purposes, measurexlite would become completely mockable (as it is now) with an explicit dependency on the related behavior. In turn, this refactoring would clarify which netxlite functionality we use for measuring, which are legacy, and which we use for communicating with the OONI backend. That change would definitely make it obvious to modify netxlite and go in the overall direction defined by ooni/probe#2531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall idea at this point is that we will have an interface containing the methods we currently have inside *Netx and we will sever the hard dependency between measurexlite and netxlite.
We will probably still need to import some contants from netxlite but, for all effects and purposes, measurexlite would become completely mockable (as it is now) with an explicit dependency on the related behavior.
In turn, this refactoring would clarify which netxlite functionality we use for measuring, which are legacy, and which we use for communicating with the OONI backend. That change would definitely make it obvious to modify netxlite and go in the overall direction defined by ooni/probe#2531.