refactor(MeasuringNetwork): define dialers without resolver #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I initially planned on defining only the dialers with resolver
and explicitly passing &NullResolver{} to them.
But I have just realized that, instead, defining the dialers
without resolvers (which is what measurexlite needs anyway) will
allow me to rewrite the without-resolver case to be very simple
and completely ignore resolvers.
Once I have done this rewrite, we can keep the existing
implementation for legacy code, but we can also have:
1. the above-mentioned simple dialing implementation without
resolvers that fullfills measurexlite needs;
2. another implementation tailored to the needs of beacons.
So, voila, I think I now have a reasonable way forward to
introduce beacons support in netxlite.
Part of ooni/probe#2531
bassosimone
commented
Sep 12, 2023
bassosimone
commented
Sep 12, 2023
bassosimone
commented
Sep 12, 2023
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
I initially planned on defining only the dialers with resolver and
explicitly passing `&NullResolver{}` to them.
But I have just realized that, instead, defining the dialers without
resolvers (which is what measurexlite needs anyway) will allow me to
rewrite the without-resolver case to be very simple and completely
ignore resolvers.
Once I have done this rewrite, we can keep the existing implementation
for legacy code, but we can also have:
1. the above-mentioned simple dialing implementation without resolvers
that fullfills measurexlite needs;
2. another implementation tailored to the needs of beacons.
So, voila, I think I now have a reasonable way forward to introduce
beacons support in netxlite.
Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially planned on defining only the dialers with resolver and explicitly passing
&NullResolver{}to them.But I have just realized that, instead, defining the dialers without resolvers (which is what measurexlite needs anyway) will allow me to rewrite the without-resolver case to be very simple and completely ignore resolvers.
Once I have done this rewrite, we can keep the existing implementation for legacy code, but we can also have:
the above-mentioned simple dialing implementation without resolvers that fullfills measurexlite needs;
another implementation tailored to the needs of beacons.
So, voila, I think I now have a reasonable way forward to introduce beacons support in netxlite.
Part of ooni/probe#2531