refactor(measurexlite): depend on model.MeasuringNetwork #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this diff, we detach measurexlite from netxlite. It was already quite detached through functions used for testing. However, the changes we implement are allow us to test measurexlite code by changing the .Netx field of a *Trace, which means we can avoid using netxlite's singleton for new code. Another benefit of this diff is that we have clearly spelled out and packaged into an interface the dependencies required to perform measurements with measurexlite. Therefore, we can gracefully continue separating the code used for measuring from the code for contacting the backend, as detailed in ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
With this diff, we detach measurexlite from netxlite. It was already quite detached through functions used for testing. However, the changes we implement are allow us to test measurexlite code by changing the .Netx field of a *Trace, which means we can avoid using netxlite's singleton for new code. Another benefit of this diff is that we have clearly spelled out and packaged into an interface the dependencies required to perform measurements with measurexlite. Therefore, we can gracefully continue separating the code used for measuring from the code for contacting the backend, as detailed in ooni/probe#2531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this diff, we detach measurexlite from netxlite. It was already quite detached through functions used for testing. However, the changes we implement are allow us to test measurexlite code by changing the .Netx field of a *Trace, which means we can avoid using netxlite's singleton for new code.
Another benefit of this diff is that we have clearly spelled out and packaged into an interface the dependencies required to perform measurements with measurexlite. Therefore, we can gracefully continue separating the code used for measuring from the code for contacting the backend, as detailed in ooni/probe#2531.