cleanup: move measurex and tracex inside ./internal/legacy #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff moves the measurex and tracex packages inside of the ./internal/legacy package. The reason why I am doing this is because we don't plan on further developing these packages. We will just fix bugs if they arise. I am doing this change before looking into whether we could more clearly figure out the dependencies these packages need considering that we're trying to figure out and organize better how we use netxlite throughout the codebase. The overall objective of this work is to gently separate code for measuring and code for communicating with the backend to support ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff moves the measurex and tracex packages inside of the ./internal/legacy package. The reason why I am doing this is because we don't plan on further developing these packages. We will just fix bugs if they arise. I am doing this change before looking into whether we could more clearly figure out the dependencies these packages need considering that we're trying to figure out and organize better how we use netxlite throughout the codebase. The overall objective of this work is to gently separate code for measuring and code for communicating with the backend to support ooni/probe#2531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff moves the measurex and tracex packages inside of the ./internal/legacy package. The reason why I am doing this is because we don't plan on further developing these packages. We will just fix bugs if they arise.
I am doing this change before looking into whether we could more clearly figure out the dependencies these packages need considering that we're trying to figure out and organize better how we use netxlite throughout the codebase.
The overall objective of this work is to gently separate code for measuring and code for communicating with the backend to support ooni/probe#2531.