refactor: rename geolocate enginelocate #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am soon going to start addressing the underlying issue described by ooni/probe#2531. But, before doing that, I have noticed that the packets I need to edit to this end are the following: ``` ./internal/engine ./internal/geolocate ./internal/sessionresolver ``` Now, these three packages work in unison to provide an engine.Session and they should sort together. However, I would like also to avoid nesting because I think all of them servers an ~independent purpose and geolocate and sessionresolver are possibly building blocks to refactor or reimplement the engine. For this reason, I have chosen to rename them such that it is clear they are the engine and supporting packages. This diff addresses the first half of the change by renaming the geolocate package. While there acknowledge that the script to rename packages was broken and decide to ditch it for good rather than entering into the quest of fixing it. I would probably have spent lots of time trying in doing that, and my time is better spent otherwise. (I remember the official package renaming tool did not support go modules, but probably it does and I should look into giving it another spin.)
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
I am soon going to start addressing the underlying issue described by ooni/probe#2531. But, before doing that, I have noticed that the packages I need to edit to this end are the following: ``` ./internal/engine ./internal/geolocate ./internal/sessionresolver ``` Now, these three packages work in unison to provide an `engine.Session` and they should *sort* together. However, I would like also to avoid nesting because I think all of them servers an ~independent purpose and geolocate and sessionresolver are possibly building blocks to refactor or reimplement the engine. For this reason, I have chosen to rename them such that it is clear they are the engine and supporting packages. This diff addresses the first half of the change by renaming the geolocate package. While there acknowledge that the script to rename packages was broken and decide to ditch it for good rather than entering into the quest of fixing it. I would probably have spent lots of time trying in doing that, and my time is better spent otherwise. (I remember the official package renaming tool did not support go modules, but probably it does and I should look into giving it another spin.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am soon going to start addressing the underlying issue described by ooni/probe#2531.
But, before doing that, I have noticed that the packages I need to edit to this end are the following:
Now, these three packages work in unison to provide an
engine.Sessionand they should sort together. However, I would like also to avoid nesting because I think all of them servers an ~independent purpose and geolocate and sessionresolver are possibly building blocks to refactor or reimplement the engine.For this reason, I have chosen to rename them such that it is clear they are the engine and supporting packages.
This diff addresses the first half of the change by renaming the geolocate package.
While there acknowledge that the script to rename packages was broken and decide to ditch it for good rather than entering into the quest of fixing it. I would probably have spent lots of time trying in doing that, and my time is better spent otherwise. (I remember the official package renaming tool did not support go modules, but probably it does and I should look into giving it another spin.)